[Doc] Use sphinx_book_theme#10379
Merged
simon-mo merged 6 commits intoray-project:masterfrom Sep 8, 2020
Merged
Conversation
simon-mo
commented
Aug 27, 2020
doc/source/conf.py
Outdated
Comment on lines
+223
to
+245
Contributor
Author
There was a problem hiding this comment.
These should replace our custom "open an issue" button.
Contributor
Author
|
Note: We need to wait for executablebooks/sphinx-book-theme#198 to be merged and released. |
Contributor
|
@simon-mo several of the rllib tables look funny in the new theme, are there are fixes you can make to the config to make them look more compact? |
Contributor
|
I think the fix there is to do it via the scss; could look into it later this weekend. |
bllchmbrs
approved these changes
Sep 1, 2020
richardliaw
reviewed
Sep 1, 2020
Contributor
richardliaw
left a comment
richardliaw
left a comment
There was a problem hiding this comment.
TODO before merge:
- fix the tables as mentioned by eric
- make sure centering works
We may want to just override the scss file with the corresponding changes for 1.0.
simon-mo
force-pushed
the
doc/new-theme
branch
from
020f776 to
51699b1
Compare
Contributor
Author
|
@richardliaw @ericl I updated the centering and table. Image Centering
Table Compact
|
richardliaw
approved these changes
Sep 8, 2020
Contributor
|
|
simon-mo
added
the
tests-ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR updates the theme for use Sphinx Book Theme. A full rendering can be found here
Note:
Checks
scripts/format.shto lint the changes in this PR.